Skip to content

feat(stovepipe): request history api - entities/mappers - #669

Merged
mnoah1 merged 4 commits into
mainfrom
mnoah1/stovepipe-history-read-model
Sep 9, 2026
Merged

feat(stovepipe): request history api - entities/mappers#669
mnoah1 merged 4 commits into
mainfrom
mnoah1/stovepipe-history-read-model

Conversation

@mnoah1

@mnoah1 mnoah1 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Intent:

  • Make retained request logs the authority for history availability.
  • Establish the public and domain projections used by history reads.

Changes:

  • Add history entity and mapper coverage and align the RFC with log-only lookup semantics.
  • Return not found when no request log records are retained.
  • Remove unused, undeployed history fields without reserving their names or tags.

Comment thread api/stovepipe/proto/stovepipe.proto
@mnoah1 mnoah1 changed the title feat(stovepipe): define request history read model feat(stovepipe): request history api - define request history read model Sep 3, 2026
@mnoah1
mnoah1 marked this pull request as ready for review September 3, 2026 01:03
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners September 3, 2026 01:03
@mnoah1 mnoah1 changed the title feat(stovepipe): request history api - define request history read model feat(stovepipe): request history api - entities/mappers Sep 3, 2026
Comment thread api/stovepipe/proto/stovepipe.proto Outdated
mnoah1 added a commit that referenced this pull request Sep 9, 2026
Summary:
Intent:
- Serve retained history by request ID without consulting operational request data.
- Preserve domain-level invalid and missing-history classifications for future transports.

Changes:
- Add the request-history controller and bounded selector validation.
- Read only the queue-scoped request log and preserve context metric tags.
- Cover successful, invalid, missing, and infrastructure outcomes.

This PR builds on #669, which defines the retained-history read model.

---

<sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
Summary:
Intent:
- Make retained request logs the authority for history availability.
- Establish the public and domain projections used by history reads.

Changes:
- Return not found when no request log records are retained.
- Reserve metadata-backed proto fields and add history entity and mapper coverage.
- Align the request history RFC with log-only lookup semantics.

---

<sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
mnoah1 added a commit that referenced this pull request Sep 9, 2026
Summary:
Intent:
- Serve retained history by request ID without consulting operational request data.
- Preserve domain-level invalid and missing-history classifications for future transports.

Changes:
- Add the request-history controller and bounded selector validation.
- Read only the queue-scoped request log and preserve context metric tags.
- Cover successful, invalid, missing, and infrastructure outcomes.

This PR builds on #669, which defines the retained-history read model.

---

<sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-history-read-model branch from ab8eed3 to cceb90b Compare September 9, 2026 15:55
@mnoah1
mnoah1 added this pull request to the merge queue Sep 9, 2026
Merged via the queue into main with commit 4f224d4 Sep 9, 2026
25 of 27 checks passed
@mnoah1
mnoah1 deployed to stack-rebase September 9, 2026 16:14 — with GitHub Actions Active
@behinddwalls
behinddwalls deleted the mnoah1/stovepipe-history-read-model branch September 9, 2026 16:14
aeonframework pushed a commit to aeonframework/submitqueue that referenced this pull request Sep 10, 2026
## Summary
Intent:
- Support history lookup from an exact commit URI while preserving
log-only authority.
- Keep the plural response model ready for a future multi-attempt URI
index.

Changes:
- Resolve the current URI mapping and load its retained request log.
- Return one grouped history under the insert-once mapping contract.
- Cover selector validation, missing history, infrastructure errors, and
metric tags.


## Stack
1. uber#669
1. uber#670
1. @ uber#671
1. uber#672
aeonframework pushed a commit to aeonframework/submitqueue that referenced this pull request Sep 10, 2026
## Summary
Intent:
- Make retained Stovepipe request history available through both
published selectors.
- Keep request-log presence authoritative without consulting operational
request rows.

Changes:
- Wire the shared request-history controller into thin gRPC handlers.
- Cover transport delegation and MySQL-backed history behavior for both
selectors.
- Document runnable grpcurl examples and retained-history discovery
semantics.


## Stack
1. uber#669
1. uber#670
1. uber#671
1. @ uber#672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants